Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokio 0.3 support #104

Closed
wants to merge 4 commits into from
Closed

Tokio 0.3 support #104

wants to merge 4 commits into from

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Oct 18, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 18, 2020 •
edited
Loading

Codecov Report

Merging #104 (936bd4d) into prīmum (74125e6) will decrease coverage by 1.44%.
The diff coverage is 83.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           prīmum     #104      +/-   ##
==========================================
- Coverage   80.08%   78.63%   -1.45%     
==========================================
  Files          62       78      +16     
  Lines        2174     2518     +344     
==========================================
+ Hits         1741     1980     +239     
- Misses        433      538     +105
Impacted Files Coverage Δ
src/lib.rs 67.74% <ø> (ø)
tests/proptest.rs 0.00% <0.00%> (ø)
src/tokio_03/bufread/macros/encoder.rs 40.00% <40.00%> (ø)
src/tokio_03/write/buf_writer.rs 51.64% <51.64%> (ø)
src/tokio_03/write/macros/encoder.rs 66.66% <66.66%> (ø)
tests/utils/input_stream.rs 66.66% <66.66%> (ø)
src/tokio_03/bufread/macros/decoder.rs 70.00% <70.00%> (ø)
src/tokio_03/write/generic/decoder.rs 71.83% <71.83%> (ø)
src/tokio_03/bufread/generic/encoder.rs 73.17% <73.17%> (ø)
src/tokio_03/write/macros/decoder.rs 75.00% <75.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74125e6...936bd4d. Read the comment docs.

@Nemo157
Copy link
Member Author

Nemo157 commented Nov 7, 2020 •
edited
Loading

Docs appear to be broken because of rust-lang/rust#76296.

EDIT: Except then saved by rust-lang/docs.rs#1165 😅.

@Nemo157
Copy link
Member Author

Nemo157 commented Nov 7, 2020

bors r+

bors bot added a commit that referenced this pull request Nov 7, 2020
@bors @Nemo157
Merge #104
796abb2 
104: Tokio 0.3 support r=Nemo157 a=Nemo157



Co-authored-by: Wim Looman <git@nemo157.com>
@bors
Copy link
Contributor

bors bot commented Nov 7, 2020

Build succeeded:

@bors bors bot closed this Nov 7, 2020
@Nemo157 Nemo157 deleted the tokio-0.3 branch November 7, 2020 15:44
@fanatid fanatid mentioned this pull request Nov 30, 2020
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @codecov-io